Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework:skip) Add function to unflatten dicts #3974

Merged
merged 3 commits into from
Aug 9, 2024
Merged

refactor(framework:skip) Add function to unflatten dicts #3974

merged 3 commits into from
Aug 9, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

jafermarq
jafermarq approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! will make user configs more versatile 💯

@danieljanes danieljanes enabled auto-merge (squash) August 9, 2024 01:40
@danieljanes danieljanes merged commit 26ba030 into main Aug 9, 2024
33 checks passed
@danieljanes danieljanes deleted the add-unflatten-func branch August 9, 2024 01:46
@jafermarq jafermarq mentioned this pull request Aug 9, 2024
Open
5 tasks
chongshenng pushed a commit that referenced this pull request Aug 13, 2024
@charlesbvll @chongshenng
refactor(framework:skip) Add function to unflatten dicts (#3974)
4b48390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@jafermarq jafermarq jafermarq approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesbvll @danieljanes @jafermarq